python312Packages.capstone: enable, add distutils patch #325882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
risicle
reviewed
Jul 9, 2024
Mrmaxmeier
force-pushed
the
python-capstone-python312
branch
from
87d199e to
a01707e
Compare
risicle
approved these changes
Jul 9, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the python bindings for
capstoneon python 3.12 by pulling in a merged but not yet released patch from upstream (capstone-engine/capstone#2271).Note:
nixpkgs-reviewis not happy because multiple dependants rely onunicornwhich is broken on python 3.12 for similar reasons. (=> #325888)Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/) <- smoke-tested python312 and python311 module functionality