Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclone: fix rclone cmount option #337243

Closed
wants to merge 1 commit into from
Closed

Conversation

poelzi
Copy link
Member

@poelzi poelzi commented Aug 25, 2024

Description of changes

rclone cmount uses cgofuse which only loads libfuse.so.2, part of fuse2

Things done

testes mount and cmount

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

rclone cmount uses cgofuse which only loads libfuse.so.2, part of fuse2
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 25, 2024
Comment on lines +53 to +54
--suffix PATH : "${lib.makeBinPath [ fuse2 ] }" \
--prefix LD_LIBRARY_PATH : "${fuse2}/lib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work, see #291268

@SuperSandro2000
Copy link
Member

The upstream Dockerfile also does it like we do https://github.com/rclone/rclone/blob/master/Dockerfile#L15

@poelzi
Copy link
Member Author

poelzi commented Aug 26, 2024

Interesting, because it is definitely broken on my system.
I tracked it down to https://github.com/winfsp/cgofuse/blob/f87f5db493b56c5f4ebe482a1b7d02c7e5d572fa/fuse/host_cgo.go#L184 and strace only showed dlopen("libfuse.so.2"...)

@SuperSandro2000
Copy link
Member

Can you try dropping LD_LIBRARY_PATH?

I hope that cgo is already tracking the library correctly.

@SuperSandro2000
Copy link
Member

Please give #337474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants