hyprland: 0.43.0 -> 0.44.0, hyprpicker: 0.3.0 -> 0.4.1 #346906
Merged
+94
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotAShelf
reviewed
Oct 7, 2024
|
Could you separate out the reformat part into a separate commit? It's impossible to tell what's going on otherwise. |
|
Seperate the mold linker commit as well. |
|
I meant the hyprpicker commit. It's fine to bundle changes and minor fixups related to an update into the update commit but automated reformats generally make it impossible to tell what other changes have actually taken place, so please separate that out into another commit. |
Atemu
approved these changes
Oct 9, 2024
fufexan
force-pushed
the
hyprland
branch
2 times, most recently
from
9ba1f38
to
621af4b
Compare
Use `inherit (lib) x` instead of `lib.x` Remove no-longer-needed jq Use importJSON
Leave open the possibility of adding multiple adapters in the future.
Follow upstream.
|
You forgot to update the info.json. This would have been caught by a simple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update hyprland and hyprpicker. More details in the commit messages.
Hyprland CHANGELOG
Hyprpicker CHANGELOG
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.