-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plover
: move into pythonPackages
and add plugins
#347354
base: master
Are you sure you want to change the base?
Conversation
I didn't understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add an application to python-modules
. If you want to add a plugin system, take a look at poetry
and nbqa
.
We also recommend that you read the python packaging guide carefully and submit several small PRs, rather than putting a lot of changes into a single PR. This makes it easier for us to review and fix.
Thanks.
My approach here is very similar to
Could you be more specific? I think this adheres to most of those points. I'll add
I didn't think this was a lot of changes — it's just a few small packages and they're mostly interdependent 😅 I can break it down into some smaller PRs but they'll need to be merged in a specific order. |
Fixes #89341.
plover
from4.0.0.dev10
to the more recent4.0.0rc2
pythonPackages
plover
fromapplications/misc
todevelopment/python-modules
to allow using it as a dependencywithPlugins
function toplover
plover-lapwing-aio
plugin and its dependenciesThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.