Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuget-to-nix: add meta.mainProgram #347459

Merged
merged 1 commit into from
Oct 9, 2024
Merged

nuget-to-nix: add meta.mainProgram #347459

merged 1 commit into from
Oct 9, 2024
+4 −1

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Oct 9, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@r-vdp r-vdp requested a review from corngood as a code owner October 9, 2024 10:34
@github-actions github-actions bot added the 6.topic: dotnet Language: .NET label Oct 9, 2024
corngood
corngood approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@corngood corngood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@corngood corngood merged commit 3edf0c2 into NixOS:master Oct 9, 2024
10 of 11 checks passed
@r-vdp r-vdp deleted the nuget-to-nix-meta branch October 9, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corngood corngood corngood approved these changes

Assignees
No one assigned
Labels
6.topic: dotnet Language: .NET
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-vdp @corngood