Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seafile-server: 11.0.12 -> 12.0.7 #369550

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

seafile-server: 11.0.12 -> 12.0.7 #369550

wants to merge 5 commits into from
+313 −205

Conversation

melvyn2
Copy link
Contributor

@melvyn2 melvyn2 commented Dec 31, 2024 •
edited
Loading

https://manual.seafile.com/12.0/upgrade/upgrade_notes_for_12.0.x/

Fixes #373705 and #373703

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from schmittlauch and greizgh December 31, 2024 12:16
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 9, 2025
@melvyn2 melvyn2 changed the title seafile-server: 11.0.12 -> 12.0.6 seafile-server: 11.0.12 -> 12.0.7 Jan 14, 2025
@melvyn2 melvyn2 marked this pull request as ready for review January 14, 2025 16:58
@melvyn2
Copy link
Contributor Author

melvyn2 commented Jan 14, 2025

Version 12.0.7 is a full non-beta release, so this is ready for testing.

@qxrein
Copy link
Member

qxrein commented Jan 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369550

x86_64-linux

⏩ 9 packages marked as broken and skipped:
  • python312Packages.djangosaml2
  • python312Packages.djangosaml2.dist
  • python312Packages.pysaml2
  • python312Packages.pysaml2.dist
  • python313Packages.djangosaml2
  • python313Packages.djangosaml2.dist
  • python313Packages.pysaml2
  • python313Packages.pysaml2.dist
  • seahub
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 4 packages built:
  • seafile-server (python312Packages.seaserv)
  • python313Packages.seaserv
  • seafile-client
  • seafile-shared

@qxrein
Copy link
Member

qxrein commented Jan 14, 2025

seahub is broken due to a gcc error

@melvyn2
Copy link
Contributor Author

melvyn2 commented Jan 14, 2025

As a hack for avoiding the broken pysaml2 derivation, ADFS support could be disabled in the seahub derivation temporarily. I don't think that we have any users who require this feature, but maybe I'm wrong.

@melvyn2
Copy link
Contributor Author

melvyn2 commented Jan 14, 2025

seahub is broken due to a gcc error

I'm not running into this (even rebased onto 2f6a15c), could you send a log please?

@qxrein
Copy link
Member

qxrein commented Jan 14, 2025

I'm not running into this (even rebased onto 2f6a15c), could you send a log please?

for /by-name/se/seahub
https://paste.rs/obJ0u.txt

@melvyn2
Copy link
Contributor Author

melvyn2 commented Jan 14, 2025 •
edited
Loading

I'm not running into this (even rebased onto 2f6a15c), could you send a log please?

for /by-name/se/seahub https://paste.rs/obJ0u.txt

This is for an older libsearpc, the one on nixos-unstable is fixed. I'll try to get it backported.
#373788

@qxrein
Copy link
Member

qxrein commented Jan 14, 2025

that makes sense

@melvyn2
Copy link
Contributor Author

melvyn2 commented Jan 14, 2025

@melvyn2 clear the commit history in one single commit

I don't understand what you're asking

@qxrein
Copy link
Member

qxrein commented Jan 14, 2025

nvm sorry i didn't saw that, approving this PR

@qxrein
Copy link
Member

qxrein commented Jan 15, 2025

has merge conflits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qxrein qxrein qxrein approved these changes

@schmittlauch schmittlauch Awaiting requested review from schmittlauch

@greizgh greizgh Awaiting requested review from greizgh

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Request: seahub 11.0.12 → 12.0.7
2 participants
@melvyn2 @qxrein