ags: 1.8.2 -> 2.2.1 #373562
ags: 1.8.2 -> 2.2.1 #373562
Conversation
| ldflags = [ | ||
| "-s" | ||
| "-w" | ||
| "-X main.astalGjs=${astal.gjs}/share/astal/gjs" |
There was a problem hiding this comment.
BTW, because of this single line I wasted an entire day
github-actions
bot
added
10.rebuild-darwin: 0
|
PerchunPak
force-pushed
the
ags
branch
2 times, most recently
from
421966a to
83bd23a
Compare
github-actions
bot
added
6.topic: nixos
| @@ -212,6 +212,8 @@ | |||
| [v1.7.0](https://github.com/jtroo/kanata/releases/tag/v1.7.0) | |||
| for more information. | |||
|
|
|||
| - `ags` was updated to v2, which is brand new project with different goals. If you still need v1, use `ags_1`. | |||
There was a problem hiding this comment.
"Different" goals? Is it not used to create widgets on a WM?
There was a problem hiding this comment.
v1 is a library built for GJS to allow defining GTK widgets in a declarative way and v2 is just a CLI wrapper around esbuild (search for AGS v2 bundler)
There was a problem hiding this comment.
Perhaps v2 could be exposed as ags-cli and leave ags to v1
EDIT: I like this idea more than a breaking change
There was a problem hiding this comment.
Perhaps v2 could be exposed as
ags-cliand leaveagsto v1
No. Package name should be in line with upstream unless it causes ambiguity.
Most people (incoming and existing users) will expect that ags points to new v2, while those who need the older version should be allowed to use ags_1.
There was a problem hiding this comment.
My understanding is that most, if not all, ags_1 features have been moved to agstal.
ags_2 is just now an interpreter for Widget configs written in typescript/javascript. @Aylur that is correct I think?
There was a problem hiding this comment.
Yes, ags_1 was rewritten from scratch in Vala and C so it can be used outside of JS/TS. It was split into multiple libraries under the Astal name. ags_2 is a CLI that provides the same workflow as ags_1 so that users can jump right into it and "write a config" instead of setting up an typescript with Astal project themselves. Its basically a wrapper around esbuild. It still has the same goal as v1 though, which is to make writing widgets on WMs accessible.
I would prefer v2 to be ags and v1 to be ags_1 if I have a say in it.
github-actions
bot
removed
6.topic: nixos
github-actions
bot
added
6.topic: nixos
|
I'll get to reviewing Friday of next week. (Will be busy for work for the next week till the weekend) If anyone wants to review this and merge, they can go ahead. |
|
|
||
| meta = { | ||
| description = "Scaffolding CLI for Astal+TypeScript"; |
There was a problem hiding this comment.
As per https://github.com/NixOS/nixpkgs/pull/373562/files#r1914975896
Something like "Typescript frontend of Widget system powered by Astal"
You can put more details/explain in longDescription
There was a problem hiding this comment.
I find your description a bit difficult to follow without any background context. In comparison, the description from upstream seems a bit clearer in this regard.
nix-owners
bot
requested review from
hsjobeki,
GetPsyched and
fricklerhandwerk
github-actions
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
https://github.com/Aylur/ags: Scaffolding CLI for Astal+TypeScript
This is basically a complete rewrite (as upstream was rewritten in Go). It is required for #350324, I also built a completely functioning version of hyprpanel using this, so it totally works!
Also, it is almost 1 to 1 copy of the upstream Nix implementation, but this is much more versatile.
Closes #306446
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @FliegendeWurst @foo-dogsquared @JohnRTitor
Add a 👍 reaction to pull requests you find important.