Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlx42: fix build with clang #373838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mlx42: fix build with clang #373838

wants to merge 1 commit into from

Conversation

TomaSajt
Copy link
Contributor

Hydra failure:
https://hydra.nixos.org/build/281928086/nixlog/3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paparodeo
Copy link
Contributor

clang error: argument '-Ofast' is deprecated; use '-O3 -ffast-math' for the same behavior, or '-O3' to enable only conforming optimizations [-Werror,-Wdeprecated-ofast]
make[2]: *** [CMakeFiles/mlx42.dir/build.make:98: CMakeFiles/mlx42.dir/src/mlx_exit.c.o] Error 1

given that they are compiling with -Werror this should be reported upstream so they can fix the problem -- they may not be aware that -Ofast implies -ffast-math which is one of the reasons this is depreciated.

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jan 14, 2025

I'll report it upstream
Edit: opened: codam-coding-college/MLX42#147

Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference the issue in the patch and then LGTM

pkgs/by-name/ml/mlx42/package.nix Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants