-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrypted: init at 0.127.0 #373883
base: master
Are you sure you want to change the base?
scrypted: init at 0.127.0 #373883
Conversation
Should the package maybe be called scrypted-server? As it does not consider the other sources like the SDK or plugins (which are installed via the UI). |
|
9aba7f1
to
99336d3
Compare
Please rebase to keep 3 commits:
|
Hey @sikmir I am back from vacation and cleaned the commit history as requested. |
Init scrypted package and service at version 0.126.0
This resolves #220494
The installation procedure is based on Scrypted's Docker file. I have omitted the generic installation of the graphical or TPU drivers, as I believe the user knows best what is needed for their case.
I provided a custom build hook to skip the NPM rebuild phase, as it fails due to issues with
node-addon-api
.See #372605.
The inability to build the
@scrypted/node-pty
NPM package prevents scrypted's terminal feature from functioning, while all other features remain available. Though I don't view this as a downside, as terminal access through a Node app could be considered a security risk. Regardless, it would be great to resolve the build problem - if possible.During a dummy setup of scrypted locally, I am able to install plugins and see camera streams.
I would appreciate it if someone else could also run the test checks for building and running the package, as this is my first proper contribution.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.