Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyflame: init at 1.6.7 #51385

Merged
merged 1 commit into from
Dec 4, 2018
Merged

pyflame: init at 1.6.7 #51385

merged 1 commit into from
Dec 4, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

I wanted to try this tool yesterday. It is great :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 2, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 3, 2018

@GrahamcOfBorg build pyflame

@symphorien
Copy link
Member Author

Apparently build failures on aarch64 are known: uber-archive/pyflame#136
I'll restrict meta.platform.

@Mic92 Mic92 merged commit fc02ed8 into NixOS:master Dec 4, 2018
@symphorien symphorien deleted the pyflame branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@symphorien @Mic92 @GrahamcOfBorg