replace python3Packages with python310Packages #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so when its in commit message build it
mweinelt
reviewed
Jun 15, 2023
| @@ -34,6 +34,10 @@ const TITLE_LABELS: [(&str, &str); 4] = [ | |||
| ("cross", "6.topic: cross-compilation"), | |||
| ]; | |||
|
|
|||
| const TITLE_REPLACEMENTS: [(&str, &str); 1] = [ | |||
| ("python3Packages", "python310Packages"), | |||
There was a problem hiding this comment.
Suggested change
| ("python3Packages", "python310Packages"), | |
| ("python3Packages", "python3.pkgs"), |
That is less of a moving target and references the default python version.
There was a problem hiding this comment.
Won't work for the same reason why python3Packages won't work https://gist.github.com/GrahamcOfBorg/f9eea356a93c92631f3d2b4304070282
There was a problem hiding this comment.
So we need to bump the version here every year, when we move the default python version? Will be 3.11 in a few weeks.
There was a problem hiding this comment.
Is python311Packages now on python-updates and soon on staging.
13 tasks
|
Fixes #577, if merged? (I still have my probably-stupid question unanswered over there.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so when its in commit message build it