Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split import cells and remove env variables from notebooks #822

Merged
merged 5 commits into from
Nov 14, 2023
Merged

split import cells and remove env variables from notebooks #822

merged 5 commits into from
Nov 14, 2023

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Nov 13, 2023 •
edited
Loading

  • Splits the cell with imports and code so that the code doesn't run when building the documentation.
  • Removes the env variables set in the notebooks so that code like CUDA_VISIBLE_DEVICES='' nbdev_test allows running the tests on the CPU in a machine with a CUDA GPU.
  • Removes the span tags from some of the sections.
  • Removes break tags from the descriptions.
  • Fixes an equation in the scalers notebook.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jmoralez jmoralez changed the title set doc_baseurl as / split import cells and remove env variables from notebooks Nov 13, 2023
@jmoralez jmoralez marked this pull request as ready for review November 14, 2023 00:00
@jmoralez jmoralez requested a review from cchallu November 14, 2023 00:02
@jmoralez jmoralez merged commit 9d70858 into main Nov 14, 2023
9 checks passed
@jmoralez jmoralez deleted the docs-baseurl branch November 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchallu cchallu cchallu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmoralez @cchallu