Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixes 948 multivariate predict/val issues when n_series > 1024 #962

Conversation

elephaint
Copy link
Contributor

@elephaint elephaint commented Apr 10, 2024

By default, valid_batch_size = 1024 in BaseModel which gives an issue with BaseMultivariate if n_series > 1024. This fix simply sets the valid_batch_size =n_series, similar to how batch_size is implemented in BaseMultivariate.

Summary:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@elephaint elephaint enabled auto-merge (squash) April 10, 2024 12:41
@elephaint elephaint merged commit 63ebffd into Nixtla:main Apr 10, 2024
14 checks passed
@jmoralez jmoralez added the fix label Apr 10, 2024
@elephaint elephaint deleted the 948-tsmixerx-model-batch-size-mismatch-if-number-of-unique_ids-1024 branch April 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSMixerx model batch size mismatch if number of unique_ids > 1024
3 participants