Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new abbvs + fixed a typo #283

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

new abbvs + fixed a typo #283

wants to merge 4 commits into from

Conversation

NazaNEYn
Copy link
Contributor

What new changes did you make? Tick all applicable boxes

  • Added new abbreviation
  • Fixed the docs (README.md, CONTRIBTUING.md, etc)
  1. There was a typo in pull_request_template.md file (fixed CONTRIBTUING)
  2. added new abbvs :
    tnx, rolf, pmo, otw, idek, idfc, idfk, lmfao

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
abbreve ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 7:54AM (UTC)

@@ -0,0 +1,3 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I think this slang already exists in our records.

@@ -0,0 +1,3 @@
{
"definition": "Rolling On Floor Laughing"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean rofl? If so, then it already exists.

@@ -0,0 +1,3 @@
{
"definition": "Thank You Very Much"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Looks like this exists as well

@Njong392
Copy link
Owner

Njong392 commented Mar 1, 2023

Hello @NazaNEYn Do you need help updating this pull request?

@Njong392
Copy link
Owner

Njong392 commented Jul 6, 2024

Nazanin, I will never close this PR. Hope I can merge it someday 😉

Copy link
Contributor

@E-fais E-fais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check the website and confirm abbreves are not already listed in there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is better to have separate PR for fixing typo and adding new abbreves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants