Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context blocks #14

Merged
merged 17 commits into from
Sep 23, 2021
Merged

Context blocks #14

merged 17 commits into from
Sep 23, 2021

Conversation

stoeffel
Copy link
Contributor

@stoeffel stoeffel commented Sep 14, 2021 •
edited
Loading

fixes #8

@stoeffel stoeffel self-assigned this Sep 17, 2021
@stoeffel stoeffel force-pushed the context-blocks branch 2 times, most recently from ac29904 to a94933c Compare September 17, 2021 13:02
@stoeffel
Copy link
Contributor Author

I think something is broken 😞

@micahhahn
Copy link
Member

I think my comment above should fix the type errors!

I'd just commit that change myself, but I've been swamped with other stuff

@stoeffel
Copy link
Contributor Author

note for myself: add adr about context block design

@stoeffel stoeffel force-pushed the context-blocks branch 2 times, most recently from 39c5519 to 374309b Compare September 20, 2021 09:50
@stoeffel
Copy link
Contributor Author

stoeffel commented Sep 20, 2021 •
edited
Loading

If we want to make a context block scoped to one comment then we need to figure out when a new comment begins. Currently we just get a list of comment lines without a distinction of when a new "block" starts.
Seems like maybe we need to start with having helpers be globally available within the whole module.

@micahhahn
Copy link
Member

If we want to make a context block scoped to one comment then we need to figure out when a new comment begins. Currently we just get a list of comment lines without a distinction of when a new "block" starts.
Seems like maybe we need to start with having helpers be globally available within the whole module.

Yeah seems totally reasonable. I'm not totally convinced we want helpers locally scoped anyways.

@stoeffel stoeffel marked this pull request as ready for review September 21, 2021 18:24
@stoeffel
Copy link
Contributor Author

I think this is good enough for now.

stoeffel
stoeffel commented Sep 21, 2021
View reviewed changes
test/assets/WithContext.hs
-- Setup for examples below:
--
-- @
-- result :: Maybe [Char]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All imports from the module under verification are implicitly imported in the generated context module.

@stoeffel stoeffel changed the base branch from Start-stdout-reporter to trunk September 22, 2021 07:07
@stoeffel stoeffel changed the base branch from Start-stdout-reporter to trunk September 22, 2021 07:07
@stoeffel stoeffel merged commit 2650497 into trunk Sep 23, 2021
@stoeffel stoeffel deleted the context-blocks branch October 1, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahhahn micahhahn Awaiting requested review from micahhahn

Assignees

@stoeffel stoeffel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow helper functions in examples
2 participants
@stoeffel @micahhahn