Make hot reloading work with Elm 0.19.1 #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoeffel
reviewed
Aug 12, 2019
src/HotReload.hs
Outdated
| @@ -24,7 +24,7 @@ wrap hotReloadingPort (a, content) = | |||
| [ "// Expose the Webpack HMR API" | |||
| , "var myDisposeCallback = function() {};" | |||
| , "// simulate the HMR api exposed by webpack" | |||
| , "var moduleHot = {" | |||
| , "var module = {" | |||
There was a problem hiding this comment.
I'm worried that something else is called module and we overwrite that.
There was a problem hiding this comment.
@stoeffel Great idea! I tried using moduleHot as before and now it seems to work! Well, it automatically reloads the page. I still get the renameFile error... but it's a big progress!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to solve the error I was getting on the JS console but now:
I'm almost sure getting hot reload to work is almost there.