Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scope from params for google service #120

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

nhulsch
Copy link

@nhulsch nhulsch commented Aug 21, 2018

This is more or less the same as Pull request #119 but implements a callback url override just for the GoogleService and not globally as other services might break.

Also it doesn't change your composer.json

@ramssesable
Copy link

There is an other param to remove 'hd'

@nhulsch
Copy link
Author

nhulsch commented Jun 20, 2019

@ramssesable is 'hd' a custom parameter of your application?
in my latest tests, google doesn't accept ANY params anymore when retrieving the access_token from the /token endpoint

@ramssesable
Copy link

Isn't mine custom parameter, I just get it from the Google widget. It could be a console.developers params, because is the domain of the account i use for the project.

…ll pass the service so yii2 builds the correct url
@nhulsch
Copy link
Author

nhulsch commented Jun 28, 2019

okay, the hd= parameter is for G Suite accounts.
I've changed it to remove ANY parameter as google doesn't seem to like any from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants