-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chain ID at block number #726
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/multichain #726 +/- ##
==================================================
Coverage ? 53.73%
==================================================
Files ? 236
Lines ? 27741
Branches ? 27741
==================================================
Hits ? 14906
Misses ? 11911
Partials ? 924 ☔ View full report in Codecov by Sentry. |
f740d94
to
a478e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM with two small notes:
- There is a merge conflict that needs to be fixed before merging
- Codecov failed the CI, but I think it's fixed already in main?
a478e4b
to
d70a925
Compare
This fixes a merge error resulting in latest chain ID always being used for
eth_call
instead of using the chain ID at the block number.