Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chain ID at block number #726

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: chain ID at block number #726

merged 2 commits into from
Nov 5, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Nov 3, 2024

This fixes a merge error resulting in latest chain ID always being used for eth_call instead of using the chain ID at the block number.

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Nov 3, 2024
@Wodann Wodann requested review from alcuadrado and a team November 3, 2024 10:57
@Wodann Wodann self-assigned this Nov 3, 2024
Copy link

changeset-bot bot commented Nov 3, 2024

⚠️ No Changeset found

Latest commit: d70a925

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark November 3, 2024 10:57 — with GitHub Actions Inactive
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feat/multichain@70e0111). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/edr_optimism/src/transaction/request.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             feat/multichain     #726   +/-   ##
==================================================
  Coverage                   ?   53.73%           
==================================================
  Files                      ?      236           
  Lines                      ?    27741           
  Branches                   ?    27741           
==================================================
  Hits                       ?    14906           
  Misses                     ?    11911           
  Partials                   ?      924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann temporarily deployed to github-action-benchmark November 3, 2024 16:08 — with GitHub Actions Inactive
Base automatically changed from fix/op-sepolia to feat/multichain November 5, 2024 14:07
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM with two small notes:

  • There is a merge conflict that needs to be fixed before merging
  • Codecov failed the CI, but I think it's fixed already in main?

@Wodann Wodann temporarily deployed to github-action-benchmark November 5, 2024 15:03 — with GitHub Actions Inactive
@Wodann Wodann merged commit a57395b into feat/multichain Nov 5, 2024
40 of 41 checks passed
@Wodann Wodann deleted the fix/op-chain-id branch November 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants