-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add writeLocalhostDeployment to deploy command #816
add writeLocalhostDeployment to deploy command #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall! I did add one small suggestion for the wording of the flag description. Also, can you add a unit test for this case as well. Once those two things are taken care of this looks good to merge 👍
packages/hardhat-plugin/src/index.ts
Outdated
@@ -93,6 +93,10 @@ ignitionScope | |||
.addOptionalParam("strategy", "Set the deployment strategy to use", "basic") | |||
.addFlag("reset", "Wipes the existing deployment state before deploying") | |||
.addFlag("verify", "Verify the deployment on Etherscan") | |||
.addFlag( | |||
"writeLocalhostDeployment", | |||
"Write deployment information to disk even when running for in-memory networks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Write deployment information to disk even when running for in-memory networks" | |
"Write deployment information to disk when deploying to the in-memory network" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the PR!
Thanks for merging! Excited for this to be included in the next release so we can use it easily! |
This is an alternative to #809 to also solve #791