Add final Clippy lints

.cargo/config.toml

@@ -11,12 +11,19 @@ lto = true
 rustflags = [
 	# rustc additional warnings:
 	"-Wunused_crate_dependencies",
+	"-Wunused_lifetimes",
+	"-Wunused_macro_rules",
+	"-Wunused_tuple_struct_fields", # Will be uplifed into `dead_code` (warn-by-default) with https://github.com/rust-lang/rust/pull/118297
+	"-Wmeta_variable_misuse",
 	# Rust 2018 idioms that are not yet warn-by-default:
 	"-Welided_lifetimes_in_paths",
 	"-Wunused_extern_crates",
 	"-Wexplicit_outlives_requirements",
 	# 📎 Lints that are enabled (warn/deny) by default
 	"-Wclippy::all",
+	# Cargo
+	"-Wclippy::cargo",                   # Warn about Cargo.toml issues, except...
+	"-Aclippy::multiple_crate_versions", # Not possible to deduplicate, should be done periodically ourselves
 	# Restriction (optional, neutral lints)
 	"-Wclippy::exit",                            # Prefer not `process::exit`ing directly
 	"-Wclippy::rest_pat_in_fully_bound_structs", # Prefer not to use `..` in fully bound structs
@@ -30,4 +37,8 @@ rustflags = [
 	"-Aclippy::module_name_repetitions",            # It seems we prefer it this way; we'd need to discuss that
 	"-Aclippy::must_use_candidate",                 # Overzealous, we'd have to `[must_use]` a lot of things
 	"-Aclippy::redundant_closure_for_method_calls", # Not always clearer, let's not pepper `allow`s whenever needed
+	# Nursery
+	"-Wclippy::collection_is_never_read", # Lint against collections not used after creation
+	"-Wclippy::equatable_if_let",         # Prefer regular `==` checks over Yoda `if let $pat = $value`
+	"-Wclippy::useless_let_if_seq",       # Use idiomatic direct assignment of `let $val = if $cond { .. } else { ..};`
 ]

crates/codegen/parser/runtime/src/support/context.rs

@@ -120,14 +120,14 @@ pub(crate) struct DelimiterGuard<'a, 's> {
     closing_delim: TokenKind,
 }
 
-impl<'a, 's> Drop for DelimiterGuard<'a, 's> {
+impl Drop for DelimiterGuard<'_, '_> {
     fn drop(&mut self) {
         let popped = self.input.closing_delimiters.pop();
         debug_assert_eq!(popped, Some(self.closing_delim));
     }
 }
 
-impl<'a, 's> DelimiterGuard<'a, 's> {
+impl<'s> DelimiterGuard<'_, 's> {
     pub(crate) fn ctx(&mut self) -> &mut ParserContext<'s> {
         self.input
     }

crates/codegen/parser/runtime/src/support/precedence_helper.rs

@@ -224,14 +224,10 @@ impl PrecedenceHelper {
 
                 // 3. Until we have a single expression.
 
-                if pratt_elements.len() != 1 {
-                    unreachable!("Expected a single element: {:#?}", pratt_elements)
-                }
-
-                if let Expression { nodes } = pratt_elements.pop().unwrap() {
-                    ParserResult::r#match(nodes, vec![])
-                } else {
-                    unreachable!("Expected an expression: {:#?}", pratt_elements)
+                match <[_; 1]>::try_from(pratt_elements) {
+                    Ok([Expression { nodes }]) => ParserResult::r#match(nodes, vec![]),
+                    Ok([head]) => unreachable!("Expected an expression: {:#?}", head),
+                    Err(elems) => unreachable!("Expected a single element: {:#?}", elems),
                 }
             }
 

crates/codegen/parser/runtime/src/support/scanner_macros.rs

@@ -1,7 +1,7 @@
 #[allow(unused_macros)]
 macro_rules! scan_chars {
     ($stream:ident, $($char:literal),+) => {
-        if $( $stream.next() == Some($char) )&&* {
+        if $( $stream.next() == Some($char) )&&+ {
             true
         } else {
             $stream.undo();
@@ -14,7 +14,7 @@ macro_rules! scan_chars {
 macro_rules! scan_none_of {
     ($stream:ident, $($char:literal),+) => {
         if let Some(c) = $stream.next() {
-            if $(c != $char)&&* {
+            if $(c != $char)&&+ {
                 true
             } else {
                 $stream.undo();

crates/codegen/schema/src/json_schema.rs

@@ -51,10 +51,8 @@ fn relax_schema(value: Value) -> Value {
                     .into_iter()
                     .filter_map(|(key, value)| {
                         // Remove `additionalProperties: false`
-                        if key == "additionalProperties" {
-                            if let Value::Bool(false) = value {
-                                return None;
-                            }
+                        if key == "additionalProperties" && value == Value::Bool(false) {
+                            return None;
                         }
 
                         // Replace `oneOf` and `allOf` with `anyOf`