Add allow_multicast flags from mesh config to starcast integration #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrasherLT
force-pushed
the
LLT-5108_Filter_multicast_peers_by_allow_multicast_flag
branch
2 times, most recently
from
e047188
to
17ade56
Compare
ThrasherLT
force-pushed
the
LLT-5108_Filter_multicast_peers_by_allow_multicast_flag
branch
3 times, most recently
from
e8bfe10
to
bfdb1ba
Compare
ThrasherLT
force-pushed
the
LLT-5108_Filter_multicast_peers_by_allow_multicast_flag
branch
from
5e78515
to
5d61d89
Compare
ThrasherLT
force-pushed
the
LLT-5108_Filter_multicast_peers_by_allow_multicast_flag
branch
from
e2bb1b0
to
35490ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
allow_multicastandpeer_allow_multicastflags are present in mesh config, but not implemented in starcast yet.Solution
Add code that removes peers from multicast peer list if we have
allow_multicastset to false for them and prevent starcast from sending multicast packets to peers who havepeer_allow_multicastset to false, but still receive multicast packets from those peers.☑️ Definition of Done checklist