[LLT-5563] Add domain name to core-api #866
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekoliinyk
force-pushed
the
LLT-5563_add_core_api_dns_record
branch
8 times, most recently
from
6c49e59
to
9643480
Compare
olekoliinyk
changed the title
olekoliinyk
force-pushed
the
LLT-5563_add_core_api_dns_record
branch
from
9643480
to
1f8a21b
Compare
Jauler
reviewed
Oct 16, 2024
| @@ -64,7 +66,7 @@ async def test_nc_register(): | |||
| async with AsyncExitStack() as exit_stack: | |||
| # Setup connections | |||
| connection_beta = await exit_stack.enter_async_context( | |||
There was a problem hiding this comment.
For this test, I do not think you need client container, you should be able to do it from the test itself directly. Just you will need to get the certificate file from the respective container.
But I guess this is out of scope of this PR specifically.
But at least I think there is no need to add new client for this test. It is ok to reuse cone client 2 or even cone_client_1 for the request.
olekoliinyk
force-pushed
the
LLT-5563_add_core_api_dns_record
branch
12 times, most recently
from
d30daed
to
730efd3
Compare
olekoliinyk
force-pushed
the
LLT-5563_add_core_api_dns_record
branch
from
730efd3
to
eba49fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add api.nordvpn.com domain name to core-api.
Self-signed certificate is generated with api.nordvpn.com domain name as we're expecting https connection.
Solution
--describe selected solution--
☑️ Definition of Done checklist