-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed ports as per issue #3 #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (trivial change).
However to not break user experience we need to keep the service also exposed on the previously used ports.
Thanks for replying @coderbyheart ; learnt this new thing today that we indeed need to keep the service alive on old ports for not breaking end user experience. Will work on it and get back to you for more learning and guidance. Thanks again. |
Hi @coderbyheart , please review . Besides the changes made, i did not add old ports in the client.go file as , i guess, we want new clients to access the server on new ports, although, clients with old ports may still continue to access the service. I have already learnt a thing or two from this work. Looking forward to your further guidance and mentoring on this. Thanks again ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests needed that demonstrate that old ports are still used. Client.go can be modified since it's only used for testing.
Hi @coderbyheart , thanks for being with me all along. Have added the tests for both old and new ports, please check and review and let me know for modifications / improvements. Thanks ! |
client/client.go
Outdated
var udpAddr string | ||
var dtlsAddr string | ||
_ = dtlsAddr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it crept in while testing locally i guess. Removed it. :-)
server/server.go
Outdated
|
||
} | ||
|
||
func launchServer(flagValues flags, udpPort int, dtlsPort int, r *mux.Router) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to new module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the guidance, yes, moved it like this --> 7938d5c
Hi @coderbyheart request you to please review the changes for issue #3 and please comment on any further modifications. Thank you.