zcbor.py: Add basic support for .default in code generation. #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
cddl-.default
branch
4 times, most recently
from
f79077e
to
c597e47
Compare
oyvindronningstad
requested review from
hakonfam,
karstenkoenig,
jonathannilsen and
anhmolt
karstenkoenig
approved these changes
Nov 19, 2024
Support for default values in INT, TSTR, BSTR, FLOAT, BOOL Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
cddl-.default
branch
from
c597e47
to
552aed3
Compare
There was a problem hiding this comment.
Thanks, @karstenkoenig, fixed your comments. I made some more changes as well, because the code was generating different types files for encode vs. decode, which is bad when generating both at the same time (they share the types file).
karstenkoenig
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for default values in INT, TSTR, BSTR, FLOAT, BOOL
Fixes #412