feat/login records #289
Merged
feat/login records #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感覺寫成 decorator 比較適合？ |
decorator 的用法會長怎樣？目前我是覺得這樣可以接受，但如果有更適合的做法也不錯 |
我只是覺得如果之後還有其他地方要紀錄的話會比較麻煩 |
那我傾向等其他地方需要再說 |
那我沒問題了，但建議要上之前在測試機跑一下。 |
|
是類似於 @logs_ip(action_type, user_id, success) 嗎？ |
signature 應該不會長這樣吧（user_id, success 大概要登入後才會知道？），但概念上我想是差不多 |
|
先 merge 囉，該部了 |
|
BTW 下次可能可以 rebase 整理一下，刪掉多餘的 commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP is logged in LoginRecords, as requested in [#287]