Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RowRef behavior on unknown languages; Add RawRow and RawSubrow #95

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

WorkingRobot
Copy link
Contributor

No description provided.

Haselnussbomber

This comment was marked as duplicate.

@Haselnussbomber

This comment was marked as outdated.

@Haselnussbomber
Copy link
Contributor

I think the only thing still missing is a way to get rows from RawExcelSheet (which you get from calling GameData.Excel.GetRawSheet()).

@WorkingRobot
Copy link
Contributor Author

I think the only thing still missing is a way to get rows from RawExcelSheet (which you get from calling GameData.Excel.GetRawSheet()).

ExcelSheet has a constructor for this very reason. You can use new ExcelSheet<RawRow>(rawSheet).GetRow(...). Ideally, if you only want to work with raw rows/subrows, use ExcelModule.GetSheet<RawRow/RawSubrow>(lang, name) explicitly.

@NotAdam NotAdam merged commit 7d4eaa7 into NotAdam:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants