Fix youtube embed starting at specific timestamp #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @martin-lacko-rebood 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Youtube embedded video with specific timestamps doesn't open on said timestamp when played
I've noticed that embedding a video to notion page with a specific timestamp is properly supported by notion itself, but when said page is rendered using react-notion-x renderer, the video simply starts from the beginning.
I believe this is not expected behaviour so I had a look. It appears the component used to render the youtube video (
LiteYouTubeEmbed) itself does supportparams, however those params were actually never passed to said component. I added simple parse function for the URL search params that returns them as aRecord<string, string>and pass those params down to the component which solves the issue. I'm calling the function itselfgetUrlParamsnotgetYoutubeUrlParamsbecause it has no relation to youtube URLs themselves, it simply returnsparamsfrom whatever url is provided thus can be used elsewhere as well.Notion Test Page ID -> 769e7a8e652a42518a9780e804ae97cf
Fixes #321