Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkbox style closer to notion's #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FranciscoMoretti
Copy link

Description

Make checkbox style match notion's in the aspects described in this issue #356.

The checkbox visuals are a bit inconsistent with an official notion page.

  • For checked: The size of the check mark is a bit bigger in react-notion-x
  • For unchecked: The border is a bit thinner in react-notion-x

Notion Test Page ID

Comparison:

from react-notion-x vertical

from_react_notion_x_vertical

From notion.so vertical

from_notion_so_vertical

New checkbox vertical

new_checkbox_vertical

Each individual image with the link to the test page:

From minimal example react-notion-x page
https://react-notion-x-demo.transitivebullsh.it/38fa73d49b8f40aab1f3f8c82332e518
from_react_notion_x

From notion.so example page
https://www.notion.so/Checklists-38fa73d49b8f40aab1f3f8c82332e518
from_notion_so

Nex checkboxes in minimal example react-notion-x page
(tested locally)
new_checkbox

@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-notion-x ❌ Failed (Inspect) Aug 25, 2022 at 2:14PM (UTC)
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 2:14PM (UTC)

@FranciscoMoretti
Copy link
Author

One of the builds fail, I'm not able to see the details in Vercel. When I click details it takes me to a 404 page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant