-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add table fidget #415
base: canary
Are you sure you want to change the base?
Conversation
Co-authored-by: Willy Ogorzaly <[email protected]>
no longer planning to link ⌐◨-◨ to the wtfisnouns page. instead, will link to the homepage (that users can currently only see when not logged in) and add a link to the wtfisnouns page from there
Co-authored-by: Jesse Paterson <[email protected]>
@r4topunk is attempting to deploy a commit to the Nounspace Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks Perfect to me ! |
@j-paterson I think that one scaped the merge wars |
e9999ee
to
7a77bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has too many additional changes beyond the table fidget. Please isolate the table fidget work and create separate PRs if the other items are needed.
@j-paterson what happened with this pr? why there are so many commits after my last changes on the table fidget??? |
This is just a victim to a force push we had a while back. Try just rebasing it and force pushing. |
This PR adds a table fidget that parses CSVs and displays them as tables.
The tables are fully customizable and it's possible to use data from text, file and url.
The text and file are the same input, as far as the file button just opens a file and puts it's contents into the text input. And the url is loaded as soon as the fidget is loaded.
Obs: I loved the experience of developing fidgets, it's so cool to think about the possibilities of creations. I have always argued that the web should be modular, and this is how Nounspace works!