fix: add ref to control player url #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@r4topunk is attempting to deploy a commit to the Nounspace Team on Vercel. A member of the Team first needs to authorize it. |
j-paterson
requested changes
Jan 9, 2025
| @@ -55,8 +54,10 @@ export const Player: React.FC<PlayerProps> = ({ url }) => { | |||
| started, | |||
| ready, | |||
| }); | |||
| const latestUrlRef = useRef<string | string[]>(url); | |||
There was a problem hiding this comment.
Why are we using a Ref for this instead of a State variable
…Nounspace#510) Co-authored-by: Willy Ogorzaly <[email protected]>
Co-authored-by: sktbrd <[email protected]>
Co-authored-by: Jesse Paterson <[email protected]>
Co-authored-by: Jesse Paterson <[email protected]>
Co-authored-by: Jesse Paterson <[email protected]>
* Supabase studio had an incorrect external url causing issues accessing the supabase api in the studio
…ord to utilize it
…ce#539) Co-authored-by: Jesse Paterson <[email protected]>
Co-authored-by: sktbrd <[email protected]>
|
Can we close this one @r4topunk @j-paterson ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.