-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure sections #1535
Restructure sections #1535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, however please fix a few issues before merge
README.md
Outdated
@@ -34,175 +34,3 @@ | |||
| ✨ | **Reactive.** (Optional) [RxJS](https://github.com/ReactiveX/rxjs) API | | |||
| 🔗 | **Relational.** Built on rock-solid [SQLite](https://www.sqlite.org) foundation | | |||
| ⚠️ | **Static typing** with [Flow](https://flow.org) or [TypeScript](https://typescriptlang.org) | | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'd like to keep README the way it was before - it's used on the GitHub page, not just on docs website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it maybe make sense to create a separate file to have the shortened readme for the docs website and then have the readme reverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'm not sure yet. I worry this would be an extra maintenance burden to have to update both the main README and the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I'll revert this change! Maybe someone can figure out a script to copy based off the sections. I tried asking around some forums and googling but to no avail ahha
@@ -3,22 +3,33 @@ title: Contributing | |||
hide_title: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be made in CONTRIBUTING file, as this one simply mirrors it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean I should make the changes only in the contributing file or in both? I'm assuming you mean both but I just want to make sure ahaha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in CONTRIBUTING, yarn docs:dev
does the update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to run yarn docs:dev
manually? When I run it manually, it errors out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try ./scripts/update-docusaurus
. If doesn't work, what does it say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh I just realized it is probably is because I ran it on Windows. The error is '.\scripts\update-docusaurus' is not recognized as an internal or external command, operable program or batch file.
I guess I'll just have to clone the repo on my Mac VM
@radex Updated with fixes |
thanks! |
As per described here: #1481 (comment)
I didn't add types as I don't use TypeScript and have no experience in it so I was worried about messing up haha