Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure sections #1535

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Restructure sections #1535

merged 4 commits into from
Feb 27, 2023

Conversation

KrisLau
Copy link
Contributor

@KrisLau KrisLau commented Feb 15, 2023

As per described here: #1481 (comment)

I didn't add types as I don't use TypeScript and have no experience in it so I was worried about messing up haha

Copy link
Collaborator

@radex radex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, however please fix a few issues before merge

README.md Outdated
@@ -34,175 +34,3 @@
| ✨ | **Reactive.** (Optional) [RxJS](https://github.com/ReactiveX/rxjs) API |
| 🔗 | **Relational.** Built on rock-solid [SQLite](https://www.sqlite.org) foundation |
| ⚠️ | **Static typing** with [Flow](https://flow.org) or [TypeScript](https://typescriptlang.org) |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'd like to keep README the way it was before - it's used on the GitHub page, not just on docs website

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it maybe make sense to create a separate file to have the shortened readme for the docs website and then have the readme reverted?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm not sure yet. I worry this would be an extra maintenance burden to have to update both the main README and the docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll revert this change! Maybe someone can figure out a script to copy based off the sections. I tried asking around some forums and googling but to no avail ahha

@@ -3,22 +3,33 @@ title: Contributing
hide_title: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be made in CONTRIBUTING file, as this one simply mirrors it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean I should make the changes only in the contributing file or in both? I'm assuming you mean both but I just want to make sure ahaha

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in CONTRIBUTING, yarn docs:dev does the update

Copy link
Contributor Author

@KrisLau KrisLau Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to run yarn docs:dev manually? When I run it manually, it errors out

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try ./scripts/update-docusaurus. If doesn't work, what does it say?

Copy link
Contributor Author

@KrisLau KrisLau Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh I just realized it is probably is because I ran it on Windows. The error is '.\scripts\update-docusaurus' is not recognized as an internal or external command, operable program or batch file. I guess I'll just have to clone the repo on my Mac VM

@KrisLau
Copy link
Contributor Author

KrisLau commented Feb 23, 2023

@radex Updated with fixes

@radex radex merged commit 6debc7a into Nozbe:master Feb 27, 2023
@radex
Copy link
Collaborator

radex commented Feb 27, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants