-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal for filtering DotnetPlatform packages from Gallery serach by default #13177
base: dev
Are you sure you want to change the base?
Conversation
Frankly I'd suggest showing nothing there for workload-related packages. If we did show anything we'd have to somehow detect which top-level workload a particular package belonged to, and that would involve parsing workload content which is a thing the NuGet team may not be inclined to do. |
Yeah as long as |
4e92ca2
to
d2809f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight-forward proposal to me. I think the only thing missing is what is the proposed PackageType
naming for the workloads type? Are you proposing any specific name here or should we just call it Workloads
or DotnetWorkloads
?
There are already workload packages today, that have Example: https://www.nuget.org/packages/Microsoft.NETCore.App.Runtime.Mono.android-arm64 I believe all current workload packages are this way. |
@JonDouglas do you have any insight into the other packages that use this existing PackageType? would it massively negatively impact those packages (if any) if NuGet.org made a change to the default search filters? |
@baronfel We can detect the https://www.nuget.org/packages?q=&packagetype=DotnetPlatform&prerel=true&sortby=relevance So now that I understand these already have a packagetype, what type of experience are we wanting here? For these workload packages to move to a new packagetype, for us to recognize Here's more thoughts now:
The question i have now is if we need a new packagetype or if we just reuse the existing one. I don't have a good answer on that one. |
@JonDouglas if y'all are down for it, something like
There are 75 packages that aren't authored by Microsoft that have this package type already, but those mostly seem to be in the bucket of 'users cannot install this directly' already, so it seems correct to filter this. |
sounds reasonable to me but let's let some others chime in here. we don't expect folks to be interfacing with these platform packages much in other words and want to hide them for now. |
Is there a usecase of searching or browsing workload packages on NuGet.org? |
I don't believe so - the only way to reasonably search for workloads is via At the same time, there's no direct pointer in the NuGet metadata between workload packs and the manifest(s) they belong to, so there's not a reasonable way to link a pack to the Together, this makes me want to remove them from general search entirely. They should be available to search in explicitly-selected DotnetPackage PackageType searches, and of course a specific package link should always be visible in the UI. |
Yep this sounds sensible. We may need to just revisit this proposal to include this then. If we head in this direction, maybe later down the line we would consider @jonathanpeppers proposals when we can actually point people to easy workload commands and make it easier to search for them if that time ever comes. I could imagine in a while that there may be a "Workloads" category or search that lists popular workloads one can copy/paste the CLI command or get instructions on how to acquire in other tooling down the line. |
I've updated the spec to capture two distinct behavioral changes we'd like, both of with are focused on the Gallery. I've updated the description here to match as well. |
|
||
Concretely, we'd like to suggest two orthogonal changes to the way the NuGet gallery treats `DotnetPlatform` packages: | ||
|
||
1) change the default free-form search filter to filter out `DotnetPlatform` packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can link https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1213 as well, which is basically the install time failure if you attempt to install these packages.
That strengthens the case that these should be excluded from the default search.
After some discussion today with members of the SDK, MAUI, and Aspire teams, we think that for high-profile frameworks like MAUI/Aspire the NuGet.org search experience for users is muddled by the inclusion of Workload-related packages in the search results.
We think that given workloads are A Thing ™️ in the .NET Ecosystem at this point, it makes sense to filter them from the default search experience, as well as removing incorrect installation instructions from their display. Please let me know what you think!
Rendered Proposal
Please 👍 or 👎 this comment to help us with the direction of this feature & leave as much feedback/questions/concerns as you'd like on this issue itself and we will get back to you shortly.
Thank You 🎉