Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change protected overload of PackageManager.InstallPackage to be public #61

Open
wants to merge 2 commits into
base: 2.13
Choose a base branch
from

Conversation

glennblock
Copy link

@glennblock glennblock commented Feb 16, 2017

scriptcs relies on NuGet.Core. We started having issues recently as whenever we installed NuGet Packages that also support .NET Standard / .NET Core, we started getting all the core packages, even though they are not needed.

Looking through the code I noticed that targetFramework is always forced to null in the public InstallPackage overloads. This meant I had to create my own derived PackageManager class just to expose the protected overload. You can see I did that here. For users of NuGet.Core, I'd argue it's reasonable for them to be able to force the target version without having to derive.

@dnfclas
Copy link

dnfclas commented Feb 16, 2017

Hi @glennblock, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Feb 16, 2017

@glennblock, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@ghost ghost removed the cla-signed label Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants