Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDKMigration] Update Gallery.CredentialExpiration to use ManagedIdentity #10297

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ryuyu
Copy link
Contributor

@ryuyu ryuyu commented Dec 5, 2024

Update Gallery.CredentialExpiration job to use Managed Identity for storage access.
This changeset also includes changes to add a new setting for local development.

Adding "Local_Development": boolean to the top level of app.json will now inject the relevant TokenCredential for use (DefaultAzureCredential for local development true, and ManagedIdentityCredential for local development false).

@drewgillies
Copy link
Contributor

Discussed offline--the only potential for breakage here is the DI insertion for TokenCredential, which would conflict with any preexisting ones. It's unlikely such cases exist, but if they're found we could key them individually. Ideally, we would have the same approach applied to key vault access, which we could circle back to. If there are no concerns from the team and we move this approach forward, we can track that as separate work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants