Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline doc: Warn on unexpected cfgs instead of error #276

Merged
merged 2 commits into from
May 9, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented May 9, 2024

No description provided.

@NobodyXu NobodyXu merged commit f7095ba into main May 9, 2024
16 checks passed
@NobodyXu NobodyXu deleted the NobodyXu-patch-1 branch May 9, 2024 12:40
@github-actions github-actions bot mentioned this pull request May 9, 2024
@Urgau
Copy link

Urgau commented May 24, 2024

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

Footnotes

  1. take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented May 24, 2024

Thanks!

I would see if I can use it instead and open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants