Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: improve performance #18

Merged
merged 2 commits into from
Jul 1, 2024
Merged

search: improve performance #18

merged 2 commits into from
Jul 1, 2024

Conversation

MarcelCoding
Copy link
Member

@MarcelCoding MarcelCoding commented Jun 30, 2024

  • limit maximum number of results to 50
  • use trackBy
  • improve search logic

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jun 30, 2024

We also need to update the pnpmDeps hash when changing the lock file. If that becomes a problem we could build an action which amends that.

We don't have a develop deployment to test out the changes? Would that be worth it?

@MarcelCoding
Copy link
Member Author

MarcelCoding commented Jul 1, 2024

Yeah, but when I saw the failing action I've already put my laptop away. I'll do it today evening.

We have the demo deployment which currently only works locally... You could do a nix build github:nuschtos/search#performance and starts a simple python server in the result directory. We could check it some kind of pull request deployment would be doable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants