Add script to automatically remove accepted ontologies #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
reviewed
Nov 19, 2022
|
|
||
| # Remove folders corresponding to active ontologies | ||
| for directory in DASHBOARD_DIRECTORY.iterdir(): | ||
| if directory.is_dir() and directory.name in prefixes: |
There was a problem hiding this comment.
There is already an action that deals with cleaning the directory. Only the yaml file needs to be edited! The rest happens automatically!
matentzn
requested changes
Nov 19, 2022
There was a problem hiding this comment.
Awesome, thank you!
The dir deletion is unnecessary (dealt with by https://github.com/OBOFoundry/obo-nor.github.io/blob/master/.github/workflows/dashboard.yml) and we should always make PRs, instead of committing to master. This way, when the change is merged, the dashboard is automatically rebuild as well!
| git config --local user.name "GitHub Action" | ||
| git add --all | ||
| git commit -m "Automatically remove accepted ontologies" -a | ||
| - name: Push changes |
There was a problem hiding this comment.
Please pull request instead - I prefer not to commit to master..
https://github.com/OBOFoundry/obo-nor.github.io/blob/master/.github/workflows/dashboard.yml#L31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
This PR does the following:
toxfile with appropriate configuration to run this script reproduciblyAfter accepting this and running the script via GitHub Actions, the T4FS ontology should get removed.
This took about 15 minutes to write ;)