Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][OU-ADD] website_sale: Nothing to do #4687

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

pilarvargas-tecnativa
Copy link
Contributor

cc @Tecnativa TT51563

@legalsylvain
Copy link
Contributor

legalsylvain commented Dec 5, 2024

/ocabot migration website_sale

Depends on :

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should include merging website_sale_digital into website_sale and run the query @dansanti proposes in #4561 (comment)

@pilarvargas-tecnativa
Copy link
Contributor Author

I think this PR should include merging website_sale_digital into website_sale and run the query @dansanti proposes in #4561 (comment)

Hello @hbrunn ,

Thank you for your suggestion. It is preferable to make a different PR for each module. The website_sale_digital script will be done later. Although it's always welcome if you prefer to do it yourself to get ahead of the work.

Regards

@dansanti
Copy link

hi! @pilarvargas-tecnativa website_sale_digital was merged with website_sale please add this scripts:

openupgrade.logged_query(
    env.cr,
    """
    UPDATE product_document
    SET attached_on = 'sale_order'
    FROM ir_attachment ir
    WHERE product_document.ir_attachment_id = ir.id
      AND ir.product_downloadable = TRUE
    """
)```

@pilarvargas-tecnativa
Copy link
Contributor Author

hi! @pilarvargas-tecnativa website_sale_digital was merged with website_sale please add this scripts:

Hi @dansanti thanks for your work. I had already commented it with @hbrunn before but I reiterate my words, it's better to make a separate PR for each module. I take into account your suggestions to do it later but it's always welcome if someone wants to do that PR.

My regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants