Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] mrp_analytic: remove duplicate field #579

Merged
merged 2 commits into from
Nov 18, 2023
Merged

[15.0][FIX] mrp_analytic: remove duplicate field #579

merged 2 commits into from
Nov 18, 2023

Conversation

ps-tubtim
Copy link
Member

@ps-tubtim ps-tubtim commented Jul 23, 2023 •
edited
Loading

  • Add an Analytic Tags field to Manufacturing Order
  • Remove an Analytic Account field because the field is already in core.

Before
Selection_119

After
Selection_120

AaronHForgeFlow
AaronHForgeFlow approved these changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the duplicate field and the dependency fixing should be done for sure. Ok with the new feature for the analytic tags, the improvement makes sense.

@ps-tubtim ps-tubtim force-pushed the 15.0-fix-mrp_analytic branch 3 times, most recently from 206b8c7 to 439c235 Compare July 23, 2023 10:37
Saran440
Saran440 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dreispt
Copy link
Member

dreispt commented Nov 18, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-579-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ae7b668 into OCA:15.0 Nov 18, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c9f02b1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ps-tubtim @dreispt @OCA-git-bot @AaronHForgeFlow @Saran440