[16.0][ADD] analytic_mixin_analytic_accounts_and_plans #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please avoid plurals in module names, and I would say that this requires a shorter name that summarizes the goal of the module. |
|
I suggested "accounts" and "plans" since they are many2many fields. But I am fine with "account" and "plan". What would be a good shorter name?
|
|
What about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #565. See also PR 1207 for account_financial_report.
account.move.linenew fields:analytic_account_ids(useful foraccount_financial_report)analytic_account_names(introduced in [16.0][ADD] analytic_mixin_analytic_account #565)analytic_plan_ids(introduced by me)analytic_plan_names(for consistency, but I don't need it)The compute method in
account_financial_report(AGPL) is written for stored fields, with good performance.The compute method in #565 (LGPL) is written for non-stored fields.
QUESTIONS
account_financial_reportdepends on this module foranalytic_account_ids, will the performance suffer?analytic_account_ids, can both be used in the same database?