-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] account_analytic_organization: New module account_analytic_organization #691
[16.0][ADD] account_analytic_organization: New module account_analytic_organization #691
Conversation
0711d9e
to
f048a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, tested in runboat and code review. LGTM!
f048a2b
to
a4eb9b6
Compare
Hello again @mpascuall , I missed to check the form view for the new model 'account.analytic.organization' in the previous review. As this new model has a single field ('name') I think would be much useful using inline edition in the list view instead of using the form view. What do you think? |
a4eb9b6
to
4f5628d
Compare
Hi! You're absolutely right, thanks for the feedback! Could you please review again? |
4f5628d
to
4a00107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review. LGTM.
Hi @pedrobaeza , Could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 2c9c9ea. Thanks a lot for contributing to OCA. ❤️ |
This module adds a new field on the partner. This organization field is also added on the account analytic line and account move line so you can filter and group by it.
cc https://github.com/APSL 160524
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @BernatObrador @ppyczko please review