Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] account_analytic_required: make field non-company-dependant #692

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[FIX] account_analytic_required: make field non-company-dependant #692

merged 1 commit into from
Oct 30, 2024

Conversation

yajo
Copy link
Member

@yajo yajo commented Sep 19, 2024

The model account.account is already company-dependant by itself. Thus, adding a company-dependant field makes no sense.

@moduon MT-7319

EmilioPascual
EmilioPascual approved these changes Sep 19, 2024
View reviewed changes
Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rafaelbn rafaelbn added this to the 16.0 milestone Sep 20, 2024
@yajo yajo force-pushed the 16.0-account_analytic_required-not_company_dependent branch from 05afae1 to b7fcf7b Compare September 20, 2024 10:13
@yajo yajo closed this Sep 23, 2024
@yajo yajo reopened this Sep 23, 2024
rafaelbn
rafaelbn approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

/ocabot merge patch

Test are failing, if fails please @yajo review test.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-692-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 24, 2024
@OCA-git-bot
Merge PR #692 into 16.0
9dafbdb 
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-692-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Member

hbrunn commented Oct 22, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@hbrunn The rebase process failed, because command git push --force moduon tmp-pr-692:16.0-account_analytic_required-not_company_dependent failed with output:

remote: Permission to moduon/account-analytic.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/account-analytic/': The requested URL returned error: 403

@yajo
[FIX] account_analytic_required: make field non-company-dependant
e904425 
The model `account.account` is already company-dependant by itself. Thus, adding a company-dependant field makes no sense.

@moduon MT-7319
@yajo yajo force-pushed the 16.0-account_analytic_required-not_company_dependent branch from b7fcf7b to e904425 Compare October 30, 2024 10:55
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-692-by-rafaelbn-bump-patch, awaiting test results.

@yajo
Copy link
Member Author

yajo commented Oct 30, 2024

Rebased, let's see now.

@OCA-git-bot OCA-git-bot merged commit cf22ecd into OCA:16.0 Oct 30, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad60c96. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-account_analytic_required-not_company_dependent branch November 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilioPascual EmilioPascual EmilioPascual approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@hbrunn hbrunn hbrunn approved these changes

@Shide Shide Shide approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yajo @OCA-git-bot @hbrunn @Shide @rafaelbn @EmilioPascual