Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] stock_analytic #703

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[16.0][FIX] stock_analytic #703

merged 1 commit into from
Oct 21, 2024

Conversation

AungKoKoLin1997
Copy link
Contributor

This PR fixes analytic_distribution not being passed from move to move line when updated after the move line is created.

@qrtl QT4873

@AungKoKoLin1997
[FIX] stock_analytic
d2a5231 
This commit fixes analytic_distribution not being passed from move to move line when updated after the move line is created.
AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

yostashiro
yostashiro approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997
Copy link
Contributor Author

@oca/account-analytic-maintainers
Can we get this PR merged?

AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-703-by-AaronHForgeFlow-bump-minor, awaiting test results.

@AaronHForgeFlow
Copy link
Contributor

Could you please forward port this to v17?

@OCA-git-bot OCA-git-bot merged commit f005aa0 into OCA:16.0 Oct 21, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6d34f9e. Thanks a lot for contributing to OCA. ❤️

@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Oct 23, 2024
Merged
@AungKoKoLin1997
Copy link
Contributor Author

Could you please forward port this to v17?

@AaronHForgeFlow I created the PR #706.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AungKoKoLin1997 @OCA-git-bot @AaronHForgeFlow @yostashiro