[IMP] account_financial_report - group rows and hide rows with debit and credit values at 0 #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techgrrow
commented
Aug 5, 2024
techgrrow
commented
- added join_entry_ml flag to general ledger wizard. This field when flagged joins rows from the same parent record
- added flag to general ledger wizard hat hides rows with both "credit" and "debit" columns with value 0
techgrrow
force-pushed
the
16.0-add-group-invoices-and-rows-0-debit-credit
branch
2 times, most recently
from
4bed585
to
5fbb520
Compare
- added join_entry_ml flag to general ledger wizard. This field when flagged joins rows from the same parent record - added flag that hides rows with both "credit" and "debit" coluns with value 0
techgrrow
force-pushed
the
16.0-add-group-invoices-and-rows-0-debit-credit
branch
from
5fbb520
to
e4d7810
Compare
|
Hi @techgrrow , do you have any plans to finish this PR? |
|
Hi francesco-ooops, what do you mean/what should I do? I'm already using the module. |
|
@techgrrow great to know it's already working well! If you could fix precommit and add some test coverage, then it could be merged into the main branch. Thanks! |
|
@francesco-ooops ok will do as soon as I have (allocated) time! Thanks for the feedback :) |
francesco-ooops
suggested changes
Sep 3, 2024
There was a problem hiding this comment.
@techgrrow just a couple things: can you add details about these new fields' behavior/purpose in CONFIGURATION file?
Also, don't change module version in manifest, as it will be done automatically on merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.