Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_journal_lock_date: Migration to 16.0 #1509

Merged
merged 27 commits into from
Jun 6, 2023
Merged

[16.0][MIG] account_journal_lock_date: Migration to 16.0 #1509

merged 27 commits into from
Jun 6, 2023

Conversation

RodrigoBM
Copy link
Contributor

@RodrigoBM RodrigoBM mentioned this pull request Nov 28, 2022
Open
33 tasks
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-account_journal_lock_date branch 3 times, most recently from 3526b29 to 772eba0 Compare November 28, 2022 10:16
@RodrigoBM RodrigoBM changed the title 16.0 mig account journal lock date [16.0][MIG] account journal lock date Nov 30, 2022
@RodrigoBM RodrigoBM changed the title [16.0][MIG] account journal lock date [16.0][MIG] account_journal_lock_date Nov 30, 2022
@RodrigoBM RodrigoBM changed the title [16.0][MIG] account_journal_lock_date [16.0][MIG] account_journal_lock_date: Migration to 16.0 Dec 4, 2022
@rafaelbn
Copy link
Member

/ocabot migration account_journal_lock_date

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 23, 2022
@alexis-via
Copy link
Contributor

I made a PR to improve this PR factorlibre#7
It is a forward port of the fix that just landed in v14 : #1459

@alexis-via
Copy link
Contributor

When my PR will be merged, I'll approve this PR.

@RodrigoBM
Copy link
Contributor Author

@alexis-via PR merged. Thanks

@RodrigoBM
Copy link
Contributor Author

RodrigoBM commented Jan 9, 2023 •
edited
Loading

@alexis-via the tests fail.
The odoo code only checks the lock date in the posted state.
If we want to keep the logic of the tests, I think it is necessary to check this in the creation.

    @api.model_create_multi
    def create(self, vals_list):
        res = super().create(vals_list)
        res._check_fiscalyear_lock_date()
        return res

what do you think?

alexis-via
alexis-via approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@alexis-via alexis-via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-account_journal_lock_date branch from 4cc5550 to c91fd6a Compare January 13, 2023 10:30
@RodrigoBM
Copy link
Contributor Author

@alexis-via I have deleted the error check on the creation of account.move in the tests, as the tests were failing.
In odoo the lock date check is only done when moving to the posted state, so now it will be allowed to create items on lock date.

sbidoul and others added 12 commits March 21, 2023 23:14
@sbidoul @RodrigoBM
[ADD] account_journal_lock_date
0043965
@sbidoul @RodrigoBM
[FIX] account_journal_lock_date test on travis
184aa4c 
The test failed on travis (not on a local install) because the
admin users if part of the Adviser group. Make sure we have the right
group and add a test for that feature too.
@oca-transbot @RodrigoBM
OCA Transbot updated translations from Transifex
8fb5516
@oca-travis @RodrigoBM
[UPD] Update account_journal_lock_date.pot
2acb108
@sbejaoui @RodrigoBM
[MIG] - account_journal_lock_date migration to 12.0
6e1f206
@RodrigoBM
[IMP] account_journal_lock_date: two dates per journal
0464802 
- Change in journal the existing 'Lock date' by two dates, the same as in company.
- Add a wizard to allows a massive update of those dates for several journals at the same time.
@oca-travis @RodrigoBM
[UPD] Update account_journal_lock_date.pot
aec4ed9
@RodrigoBM
[IMP] account_journal_lock_date: black, isort, prettier
7208695
@RodrigoBM
[MIG] account_journal_lock_date: Migration to 13.0
c8ef6d7
@oca-travis @RodrigoBM
[UPD] Update account_journal_lock_date.pot
3101d1a
@OCA-git-bot @RodrigoBM
[UPD] README.rst
2a3f77a
@oca-transbot @RodrigoBM
Update translation files
c69bff6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_journal_lock_date/
oca-transbot and others added 15 commits March 21, 2023 23:14
@oca-transbot @RodrigoBM
Update translation files
c0deb41 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_journal_lock_date/
@Zar21 @RodrigoBM
[MIG] account_journal_lock_date: Migration to 14.0
d1787c7
@oca-travis @RodrigoBM
[UPD] Update account_journal_lock_date.pot
d7895fa
@OCA-git-bot @RodrigoBM
[UPD] README.rst
172db56
@OCA-git-bot @RodrigoBM
[IMP] update dotfiles
c28a6c1
@francesco-ooops @RodrigoBM
Translated using Weblate (Italian)
8cce1cc 
Currently translated at 20.0% (4 of 20 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_journal_lock_date/it/
@victoralmau @RodrigoBM
[FIX] account_journal_lock_date: Add post_install tag in tests to pre…
b624f10 
…vent test errors since odoo/odoo@81aac30

TT33774
@OCA-git-bot @RodrigoBM
account_journal_lock_date 14.0.1.0.1
e6c0c55
@Reyes4711-S73 @RodrigoBM
[MIG] account_journal_lock_date: Migration to 15.0
50970b8
@RodrigoBM
[UPD] Update account_journal_lock_date.pot
644bad1
@OCA-git-bot @RodrigoBM
[UPD] README.rst
b744a8d
@OCA-git-bot @RodrigoBM
account_journal_lock_date 15.0.1.0.1
5e6b398
@RodrigoBM
[IMP] : pre-commit stuff
7826f7b
@RodrigoBM
[MIG] account_journal_lock_date: Migration to 16.0
0c5b530
@alexis-via @RodrigoBM
account_journal_lock_date: no need to inherit write()
6f220a3
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-account_journal_lock_date branch from c91fd6a to 6f220a3 Compare March 21, 2023 22:21
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@RodrigoBM
Copy link
Contributor Author

@alexis-via can tou merge it? please

@RodrigoBM
Copy link
Contributor Author

@rafaelbn can tou merge it?

@alexis-via
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1509-by-alexis-via-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6dd458c into OCA:16.0 Jun 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b697ae. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astirpe astirpe astirpe approved these changes

@alexis-via alexis-via alexis-via approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.