[16.0][MIG] account_reversal (reversal usability improvements) #1725

rousseldenis · 2023-09-19T09:05:37Z

Adds reversal id field

…ed flag and reversal_id many2one (lp:c2c-addons/6.1 rev 5609)

…e reactivated when the modules are migrated

…hon module contains GPLv2

… you are in December 2013 and FY 2014 is not created yet). Add prefer_normal_period in period selection.

This reverts commit 7eb1827.

…ding _unported suffix

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Currently translated at 86.7% (26 of 30 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/ar/

Currently translated at 100.0% (30 of 30 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/nl/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/

Migration to 16.0 by expanding core features adding: - The line reason to reversal - The 'To Be Reversed' field and filter - Displaying the move reason not only for invoices

account_reversal/models/account_move.py

This commit adds the `reversal_id` field in order to improve the UX of the move reversal functionality. The field has been added to the form view close to the `reversed_entry_id` field already present in the view. This commit also introduces a constraint preventing the user to flag a move as to be reversed when a non cancelled reversal move has already been created. This allows simplifying the domain used on the `to_be_reversed` filter. Finally, it also convert the deprecated `SavepointCase` test into a `TransactionCase` one. Fixes: OCA#1761

IT-Ideas · 2023-11-14T09:48:28Z

Hello @rousseldenis, I just added a commit in order to fix #1761. Could you add it in the PR message?

After this commit, the order is - To be reversed flag - Reversal Entry - Reversal of Before, the flag was between the entries which was weird.

sbidoul · 2024-05-21T17:00:42Z

I have pushed a couple of minor fixes and clarifications.

I think it's ok to keep the module name as is to reduce migration burden for users of the module in older Odoo versions.

github-actions · 2024-09-22T12:28:06Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@ and others added 30 commits September 18, 2023 14:40

[ADD] port account_reversal from v6.0 and add features : to_be_revers…

51293b4

…ed flag and reversal_id many2one (lp:c2c-addons/6.1 rev 5609)

[MIGR] set installable to False on all the modules, the flag has to b…

2f376a1

…e reactivated when the modules are migrated

[MIGR] set account_reversal installable

3f9a571

[IMP] manifest

f3b8a6c

[FIX] encoding should be coding

dc01b23

[FIX] license mess, the whole addon is release under AGPLv3 but a pyt…

03117fa

…hon module contains GPLv2

[IMP] python formatting, OpenERP standards

c9cff7a

[FIX] remove useless type in views

bdcac9b

[FIX] one more type to remove

534b5a9

[IMP] views for version 7.0

c649a4a

[IMP] python formating

c6cfeeb

[IMP] Translation template files for all modules.

23f81b4

Launchpad automatic translations update.

1b46f69

[FIX] Avoid a crash when the next period doesn't exist (for example :…

a7c9dfe

… you are in December 2013 and FY 2014 is not created yet). Add prefer_normal_period in period selection.

Launchpad automatic translations update.

51307c1

Set all addons to uninstallable

645214c

Rename all addons to xxx_unported to be travis compliant

e903be6

Revert "Rename all addons to xxx_unported to be travis compliant"

f7700db

This reverts commit 7eb1827.

[FIX] move all unported addons into __unported__ folder instead of ad…

9131053

…ding _unported suffix

[FIX] flake8 PEP8 for module account_reversal

6c83728

Move account_reversal from __unported__ to root folder

abaded3

Move the description in README.rst

1557a2c

Set the module installable

98d3e4f

Use relative imports

5c19c6c

Size useless on char fields

261aa1f

[FIX] pylint relative imports

7e2fc13

[IMP] improve account_reversal fr translation

345c739

initial german translation (mostly)

622be60

removed extra linefeed

951b86c

Add OCA as author of OCA addons

9e02bdc

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

oca-transbot and others added 15 commits September 19, 2023 11:24

OCA Transbot updated translations from Transifex

415714d

remove obsolete .pot files [ci skip]

1adcd30

[UPD] Update account_reversal.pot

385e52d

[UPD] Update account_reversal.pot

1add3bb

OCA Transbot updated translations from Transifex

d09af4a

[FIX] account_reversal - Reverse multiple journal entries.

4a03d94

[FIX] account reversal typo

f218614

[UPD] Update account_reversal.pot

0db30b1

Update translation files

4cd33a4

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[11.0][IMP] Journal Entries to be Reversed menu

c8fac8c

[IMP] account_reversal: pre-commit stuff

90e12c8

[16.0][MIG] account_reversal

403c1a3

Migration to 16.0 by expanding core features adding: - The line reason to reversal - The 'To Be Reversed' field and filter - Displaying the move reason not only for invoices

rousseldenis force-pushed the 16.0-mig-account-reversal-dro branch from 5a36227 to 403c1a3 Compare September 19, 2023 09:24

IT-Ideas reviewed Nov 6, 2023

View reviewed changes

account_reversal/models/account_move.py Show resolved Hide resolved

sbejaoui mentioned this pull request Nov 6, 2023

[16.0][MIG] account_invoice_accrual OCA/account-closing#264

Open

IT-Ideas mentioned this pull request Nov 7, 2023

[ADD] account_reversal_usability #1771

Closed

sbidoul added this to the 16.0 milestone Jan 1, 2024

sbidoul changed the title ~~[16.0][MIG] account_reversal~~ [16.0][MIG] account_reversal (reversal usability improvements) May 21, 2024

sbidoul added 3 commits May 21, 2024 18:35

[IMP] account_reversal: improve fields ordering in view

1915f27

After this commit, the order is - To be reversed flag - Reversal Entry - Reversal of Before, the flag was between the entries which was weird.

[FIX] account_reversal: handle lines with empty label

89f1663

[IMP] account_reversal: clarify help and documentation

cfc1ec0

sbidoul approved these changes May 21, 2024

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_reversal (reversal usability improvements) #1725

[16.0][MIG] account_reversal (reversal usability improvements) #1725

rousseldenis commented Sep 19, 2023 •

edited

Loading

IT-Ideas commented Nov 14, 2023

sbidoul commented May 21, 2024

github-actions bot commented Sep 22, 2024

[16.0][MIG] account_reversal (reversal usability improvements) #1725

Are you sure you want to change the base?

[16.0][MIG] account_reversal (reversal usability improvements) #1725

Conversation

rousseldenis commented Sep 19, 2023 • edited Loading

IT-Ideas commented Nov 14, 2023

sbidoul commented May 21, 2024

github-actions bot commented Sep 22, 2024

rousseldenis commented Sep 19, 2023 •

edited

Loading