Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_lock_to_date #1732

Merged
merged 16 commits into from
Nov 13, 2024
Merged

[16.0][MIG] account_lock_to_date #1732

merged 16 commits into from
Nov 13, 2024

Conversation

SirAionTech
Copy link
Contributor

Standard migration.

@SirAionTech SirAionTech mentioned this pull request Sep 29, 2023
Open
33 tasks
@SirAionTech SirAionTech marked this pull request as ready for review September 29, 2023 15:44
@sbidoul sbidoul added this to the 16.0 milestone Jan 11, 2024
@sbidoul sbidoul changed the title [MIG] account_lock_to_date [16.0][MIG] account_lock_to_date Jan 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Jan 11, 2024

Looks like this is a duplicate of #1655

@SirAionTech SirAionTech mentioned this pull request Jan 12, 2024
Closed
@SirAionTech
Copy link
Contributor Author

Looks like this is a duplicate of #1655

Right, I'm sorry I probably didn't find that when I opened this one because it wasn't mentioning the migrated module before #1655 (comment), and it is not mentioned in #1472.
I have reviewed it and proposed to continue the migration in here.

@SirAionTech SirAionTech force-pushed the 16.0-mig-account_lock_to_date branch from ce73675 to 7a5a4fe Compare March 7, 2024 12:15
@SirAionTech SirAionTech force-pushed the 16.0-mig-account_lock_to_date branch from 7a5a4fe to 6844615 Compare May 14, 2024 08:26
@SirAionTech
Copy link
Contributor Author

Rebased.

@JordiBForgeFlow @michotm @AaronHForgeFlow @NL66278 @MiquelRForgeFlow you worked on this, would you like to have a look?

AaronHForgeFlow
AaronHForgeFlow approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

PauMAVA
PauMAVA approved these changes May 24, 2024
View reviewed changes
Copy link

@PauMAVA PauMAVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
JordiBForgeFlow and others added 13 commits September 30, 2024 09:25
@JordiBForgeFlow @SirAionTech
[add][account_lock_to_date]
589ad35
@michotm @SirAionTech
[FIX] _check_lock_date in account_lock_to_date
9cef3a7 
if move.company_id.period_lock_to_date or move.company_id.fiscalyear_lock_to_date
are not set nothing should be done.
@AaronHForgeFlow @SirAionTech
[MIG]account_lock_to_date to v12
2324ea6
@AaronHForgeFlow @SirAionTech
[UPT]account_update_lock_to_date rebranding
c7846b7
@AaronHForgeFlow @SirAionTech
[IMP] : black, isort
1eaa85a
@AaronHForgeFlow @SirAionTech
[MIG]account_lock_to_date to v13
bb6e329
@NL66278 @SirAionTech
[FIX] account_lock_to_date. No crash on error.
e4878bf 
Use ValidationError instead of UserError to prevent unfriendly message;
Prevent crash when a lock to date not yet set in company.
@NL66278 @SirAionTech
[FIX] account_lock_to_date. Correct message.
39bcf6d 
If setting the Advisor Lock To Date too early, the message instructed
the user to do the exact opposite of what he/she should do to correct
the problem.
@NL66278 @SirAionTech
[FIX] account_lock_to_date. Also adapt tests to ValidationError
1eda8a3
@NL66278 @SirAionTech
[FIX] account_lock_to_date. Exception from wizard.
b9406d4 
Also use ValidationError instead of UserError in wizard to set lock to dates.
@SirAionTech
[MIG] account_lock_to_date: Migration to 14.0
82df17e
@svalaeys @SirAionTech
Added translation using Weblate (French)
e11c1f4
@MiquelRForgeFlow @SirAionTech
[MIG] account_lock_to_date: Migration to 15.0
de2b6be
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2024
@SirAionTech
Copy link
Contributor Author

@OCA/accounting-maintainers this has enough reviews, can someone please merge?

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also functional test

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@SirAionTech
Copy link
Contributor Author

/ocabot merge nobump

Thanks!
After 12 hours still nothing.. Should we try again?

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1732-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 323facf into OCA:16.0 Nov 13, 2024
9 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5cf0b64. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PauMAVA PauMAVA PauMAVA approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.