-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] account_invoice_constraint_chronology: Migration to 17.0 #1889
Open
zuher83
wants to merge
72
commits into
OCA:17.0
Choose a base branch
from
zuher83:17.0-mig-account_invoice_constraint_chronology
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] account_invoice_constraint_chronology: Migration to 17.0 #1889
zuher83
wants to merge
72
commits into
OCA:17.0
from
zuher83:17.0-mig-account_invoice_constraint_chronology
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice_constraint_chronology [IMP] DEFAULT_SERVER_DATE_FORMAT [IMP] display formatted date with context timezone in exception popup for account_invoice_constraint_chronology addons [ADD] Add context in tests for account_invoice_constraint_chronology addons [IMP] Use exceptions.warning for account_invoice_constraint_chronology addons [IMP] Remove exclamation mark [ADD] Add .pot file for account_invoice_constraint_chronology [IMP] Use .env for account_invoice_constraint_chronology tests [IMP] Use onchange decorator, add white space at end of file, correct ypo mistake for account_invoice_constraint_chronology [IMP] Improve performance
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
It was not used in these tests anyway.
these cause Warnings during the tests
… Dedicated Credit Note Sequence
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/
Currently translated at 100.0% (5 of 5 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/
Currently translated at 100.0% (6 of 6 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/hr/
Currently translated at 100.0% (6 of 6 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/es/
Currently translated at 100.0% (6 of 6 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/pt_BR/
inv5 YYYYMM20 posted INV4 YYYYMM15 posted INV3 YYYYMM10 posted INV2 YYYYMM05 posted INV1 YYYYMM01 posted if we pass INV3 to draft and change the date to YYYYYMM15 or YYYYYMM05 it should be able to validate, but if we change the date higher than YYYYYMM15 or lower than YYYYYMM05 it should not be able to validate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/
Currently translated at 14.2% (1 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/it/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/nl/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/nl/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/nl/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/it/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/sv/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_invoice_constraint_chronology Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_invoice_constraint_chronology/pt_BR/
zuher83
force-pushed
the
17.0-mig-account_invoice_constraint_chronology
branch
from
May 27, 2024 13:51
f623eb4
to
282dd60
Compare
I've created an issue #1890 to discuss it! |
zuher83
changed the title
[17.0][MIG] account invoice constraint chronology: Migration to 17.0
[17.0][MIG] account_invoice_constraint_chronology: Migration to 17.0
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just migrated this module to version 17.0. But I think this module is incomplete or even dangerous in some cases.
In France, for example, we don't have the right to cancel or delete an invoice! If we're on May 27, 2024 and the accountant creates an invoice dated October 20, 2024 by mistake and validates it, this will systematically block the creation of invoices prior to this date of 10/20/2024. This could have serious consequences for the invoicing process.
Solution 1: Don't allow invoices to be created after today's date
Solution 2: To be more flexible, we can add an "int" field in the accounting journal, allowing invoices to be created after 3, 5 or 10, ... days (depending on the administrator's configuration) from today's date.
In the migration I didn't make any changes to implement this approach, I intended to create a new module inherited from account_invoice_constraint_chronology and implement this very important change! If you agree, I can implement it directly in the account_invoice_constraint_chronology module.
I look forward to hearing from you.