[16.0][MIG] account invoice fixed discount: Migration to 16.0 #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fixed_discount/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fixed_discount/
Odoo has changed the signature of the method `_get_fields_onchange_balance_model`.
TITUS6304658
force-pushed
the
16.0-mig-account_invoice_fixed_discount
branch
18 times, most recently
from
d09c80b
to
ca5752c
Compare
TITUS6304658
force-pushed
the
16.0-mig-account_invoice_fixed_discount
branch
from
ca5752c
to
84d1635
Compare
CRogos
suggested changes
Jul 24, 2023
Comment on lines
87
to
107
| def test_01_discounts_fixed(self): | ||
| """Tests multiple discounts in line with taxes.""" | ||
| invoice = self._create_invoice(discount_fixed=57) | ||
| with self.assertRaises(ValidationError): | ||
| invoice.invoice_line_ids.discount = 50 | ||
| invoice.invoice_line_ids._onchange_discount_fixed() | ||
| self.assertEqual(invoice.invoice_line_ids.discount, 0.00) | ||
| invoice.invoice_line_ids._onchange_price_subtotal() | ||
| invoice.line_ids.write({"recompute_tax_line": True}) | ||
| invoice._onchange_invoice_line_ids() | ||
| # compute amount total (200 - 57) * 10% | ||
| self.assertEqual(invoice.amount_total, 157.3) | ||
| self.assertEqual(invoice.invoice_line_ids.price_unit, 200.00) | ||
| self.assertEqual(invoice.invoice_line_ids.price_subtotal, 143.00) | ||
| if not cls.tax_account_id: | ||
| raise Exception("No account with user_type_id of type 'Revenue' found") | ||
|
|
||
| def test_02_discounts(self): | ||
| invoice = self._create_invoice(discount=50) | ||
| invoice.invoice_line_ids._onchange_discount() | ||
| self.assertEqual(invoice.invoice_line_ids.discount_fixed, 0.00) | ||
| self.assertEqual(invoice.invoice_line_ids.price_unit, 200.00) | ||
| self.assertEqual(invoice.invoice_line_ids.price_subtotal, 100.00) |
There was a problem hiding this comment.
Why did you remove these tests? There is no test left in this file.
|
@TITUS6304658 @CRogos In fact, the module has to be refactored due to core changes. See #1488 (comment) comments. Tests are passing but in fact... not tested. So, this one is invalid at this time being |
rousseldenis
suggested changes
Jul 24, 2023
|
/ocabot migration account_invoice_fixed_discount |
|
superseded by #1488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16.0 mig account invoice fixed discount
Migration to version 16.0