Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] sale_credit_note_reversal: module to create reversals from sales credit notes #1808

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Oct 4, 2024

Allow to revert a credit note. Standard Odoo does not allow it.

When reverting the credit note from the journal entry Standard Odoo does not link it to the Sales order, because the reversal is not an invoice. This module just ensure the reversal is a customer invoice, so it counts as invoice in the sales order.

In order to test you can just use this button in a credit note:
image

Please see that when a sales order is confirmed with negative a mount and you invoice it Odoo creates a credit note.

@ForgeFlow

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-sale_credit_note_revert branch 3 times, most recently from f9d0d7b to 4a312c7 Compare October 4, 2024 11:51
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

Copy link

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@AaronHForgeFlow AaronHForgeFlow changed the title [16.0][ADD] sale_credit_note_revert: module to create reversals from sales credit notes [16.0][ADD] sale_credit_note_reversal: module to create reversals from sales credit notes Oct 9, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants